On 17/08/18 17:14, Peter Maydell wrote: > On a SPARC host that I'm using as a build test machine, the > boot-serial-test for the SPARC guest machines takes about 65 > seconds to execute. This means that it hits the current > 60 second timer on these tests. Push the timeout up so > that it doesn't trigger spuriously on slow hosts like this one. > > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> > --- > tests/boot-serial-test.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/boot-serial-test.c b/tests/boot-serial-test.c > index 1355df924dd..fca5f2f5da9 100644 > --- a/tests/boot-serial-test.c > +++ b/tests/boot-serial-test.c > @@ -116,8 +116,8 @@ static bool check_guest_output(const testdef_t *test, int > fd) > int i, nbr = 0, pos = 0, ccnt; > char ch; > > - /* Poll serial output... Wait at most 60 seconds */ > - for (i = 0; i < 6000; ++i) { > + /* Poll serial output... Wait at most 360 seconds */ > + for (i = 0; i < 36000; ++i) { > ccnt = 0; > while (ccnt++ < 512 && (nbr = read(fd, &ch, 1)) == 1) { > if (ch == test->expect[pos]) {
Wow that is amazingly slow... however I guess it's not completely unreasonable to increase the timeout accordingly. Acked-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> ATB, Mark.