On Thu, Aug 16, 2018 at 03:38:14PM +0100, Daniel P. Berrangé wrote: > On Thu, Aug 16, 2018 at 05:34:43PM +0300, Roman Kagan wrote: > > On Tue, Jul 10, 2018 at 02:23:09PM -0300, Eduardo Habkost wrote: > > > On Tue, Jul 10, 2018 at 08:11:58PM +0300, Roman Kagan wrote: > > > > On Thu, Jun 07, 2018 at 10:47:47AM +0100, Daniel P. Berrangé wrote: > > > > > ping... > > > > > > > > > > On Mon, May 14, 2018 at 06:19:10PM +0100, Daniel P. Berrangé wrote: > > > > > > This short series fixes a flaw identified by coverity which broke > > > > > > the > > > > > > handling of multiboot modules. > > > > > > > > > > > > Daniel P. Berrangé (3): > > > > > > i386: fix regression parsing multiboot initrd modules > > > > > > i386: only parse the initrd_filename once for multiboot modules > > > > > > opts: remove redundant check for NULL parameter > > > > > > > > > > > > hw/i386/multiboot.c | 35 ++++++++++++++++------------------- > > > > > > util/qemu-option.c | 8 +++----- > > > > > > 2 files changed, 19 insertions(+), 24 deletions(-) > > > > > > > > > > > > -- > > > > > > 2.17.0 > > > > > > > > Any reason this hasn't been merged yet? > > > > > > Lack of reviews, unfortunately. I guess we don't have many > > > people familiar with the multiboot code. > > > > > > > > > > > This fixes a regression that, in particular, makes QEMU segfault when > > > > running kvm-unit-tests. > > > > > > As it is a bug fix, I will try to review merge it for the next > > > rc. > > > > Looks like it ended up missing 3.0, so kvm-unit-tests still segfault > > with the released version of QEMU :( > > Please check again, as I see it merged before 3.0:
Oh, you're right, I just ran the tests against a wrong QEMU. It's OK now indeed. Sorry for the noise, Roman.
