Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180814165954.9892-1-...@sysgo.com
Subject: [Qemu-devel] [PATCH] target/ppc: add external PID support
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/20180816130118.31841-1-berra...@redhat.com
-> patchew/20180816130118.31841-1-berra...@redhat.com
* [new tag]
patchew/20180816130415.26057-1-marcandre.lur...@redhat.com ->
patchew/20180816130415.26057-1-marcandre.lur...@redhat.com
Switched to a new branch 'test'
9019eb4c03 target/ppc: add external PID support
=== OUTPUT BEGIN ===
Checking PATCH 1/1: target/ppc: add external PID support...
ERROR: Macros with complex values should be enclosed in parenthesis
#669: FILE: target/ppc/translate.c:7165:
+#define GEN_LDEPX(name, ldop, opc2, opc3) \
+GEN_HANDLER_E(name##epx, 0x1F, opc2, opc3, \
+ 0x00000001, PPC_INTEGER, PPC2_BOOKE206),
ERROR: Macros with complex values should be enclosed in parenthesis
#688: FILE: target/ppc/translate.c:7211:
+#define GEN_STEPX(name, ldop, opc2, opc3) \
+GEN_HANDLER_E(name##epx, 0x1F, opc2, opc3, \
+ 0x00000001, PPC_INTEGER, PPC2_BOOKE206),
total: 2 errors, 0 warnings, 718 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-de...@redhat.com
