On Wed, Aug 15, 2018 at 04:29:25PM +0200, Markus Armbruster wrote: >> For the HMP or the QMP interface? > > Both.
Ok. >> If you think 'offset' is not necessary I can also drop it >> completely. > > I think it's a reasonable feature, and since you already coded it up... In that case, should size also become optional? As already suggested in this thread (and similar for QMP): On Fri, Aug 10, 2018 at 11:36:51AM +0100, Dr. David Alan Gilbert wrote: > Also, had you considered rearranging and making them optional, > for example if you do: > > val:l,filename:F,offset:i?,size:i? > > I think that would mean you can do the fairly obvious: > pmemload addr "myfile" > > with the assumption that loads the whole file. This would deviate from pmemsave/memsave, but feels more natural. How are multiple optional parameters handled? Filled from left-to-right? Regards Simon -- + privacy is necessary + using gnupg http://gnupg.org + public key id: 0x92FEFDB7E44C32F9
signature.asc
Description: PGP signature
