Thomas Huth <th...@redhat.com> writes: > On 08/14/2018 05:41 PM, Paolo Bonzini wrote: >> Thomas has been doing a lot of work on qom-test and >> device-introspection-test, >> and Laurent has ported libqos to sPAPR and co-mentored Emanuele on the >> upcoming qtest device framework. They deserve recognition. :) >> >> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> >> --- >> MAINTAINERS | 11 ++++++++++- >> 1 file changed, 10 insertions(+), 1 deletion(-) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 666e936812..657595e6be 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -1685,7 +1685,6 @@ F: qom/ >> X: qom/cpu.c >> F: tests/check-qom-interface.c >> F: tests/check-qom-proplist.c >> -F: tests/qom-test.c > > I think you could also leave the entry here ... it should not hurt if a > test has multiple maintainers. > >> QMP >> M: Markus Armbruster <arm...@redhat.com> >> @@ -1697,6 +1696,16 @@ F: scripts/qmp/ >> F: tests/qmp-test.c >> T: git git://repo.or.cz/qemu/armbru.git qapi-next >> >> +qtest >> +M: Paolo Bonzini <pbonz...@redhat.com> >> +M: Thomas Huth <th...@redhat.com> >> +M: Laurent Vivier <lviv...@redhat.com> >> +S: Maintained >> +F: qtest.c >> +F: tests/libqtest.* >> +F: tests/libqos/ >> +F: tests/*-test.c > > Basically > Acked-by: Thomas Huth <th...@redhat.com> > (and thanks for adding me here!), but I think there are even more files > related to qtest: > > $ grep -l qtest tests/*.c | grep -v 'test\.c' > tests/boot-sector.c > tests/ptimer-test-stubs.c > tests/test-arm-mptimer.c > tests/test-filter-mirror.c > tests/test-filter-redirector.c > tests/test-hmp.c > tests/test-netfilter.c > tests/test-qga.c > tests/test-rcu-list.c > tests/test-x86-cpuid-compat.c > tests/tpm-tests.c > tests/tpm-util.c > > Maybe we should "fix" this properly and move all qtest-related files > into a separate folder tests/qtest now (or at least after the current > qtest-related patch series that are currently in flight hit the master > branch)? Or rename the test-*.c files to *-test.c files?
The tests/ directory has become a bit crowded. Separating unit tests and qtests make sense to me.
