> On 10 Aug 2018, at 13:00, Gerd Hoffmann <kra...@redhat.com> wrote: > > Hi, > >> + if (cmd == SVGA_CMD_UPDATE_VERBOSE) >> + vmsvga_fifo_read(s); > > Code style. qemu wants braces unconditionally. There might be more of > this in following patches. You can use scripts/checkpatch.pl to check. > > cheers, > Gerd > Oops. Will fix for v2 of patch series. Thanks, -Liran
- [Qemu-devel] [PATCH 00/29]: vmsvga: Various fixes and enhanc... Liran Alon
- [Qemu-devel] [PATCH 01/29] vmsvga: Stop using redundant... Liran Alon
- [Qemu-devel] [PATCH 09/29] vmsvga: Account for length o... Liran Alon
- [Qemu-devel] [PATCH 05/29] vmsvga: Show registers and c... Liran Alon
- [Qemu-devel] [PATCH 04/29] vmsvga: Do not print error m... Liran Alon
- [Qemu-devel] [PATCH 21/29] vmsvga: Use AND mask bpp par... Liran Alon
- [Qemu-devel] [PATCH 10/29] vmsvga: Remove treatment of ... Liran Alon
- [Qemu-devel] [PATCH 02/29] vmsvga: Group together comma... Liran Alon
- [Qemu-devel] [PATCH 06/29] vmsvga: Fix parse of SVGA_CM... Liran Alon
- Re: [Qemu-devel] [PATCH 06/29] vmsvga: Fix parse of... Gerd Hoffmann
- Re: [Qemu-devel] [PATCH 06/29] vmsvga: Fix pars... Liran Alon
- [Qemu-devel] [PATCH 22/29] vmsvga: Increase size of cur... Liran Alon
- [Qemu-devel] [PATCH 03/29] vmsvga: Explictly mark depre... Liran Alon
- Re: [Qemu-devel] [PATCH 03/29] vmsvga: Explictly ma... Gerd Hoffmann
- [Qemu-devel] [PATCH 12/29] vmsvga: Add definitions of F... Liran Alon
- [Qemu-devel] [PATCH 08/29] vmsvga: Parse SVGA_CMD_FENCE... Liran Alon
- [Qemu-devel] [PATCH 27/29] vmsvga: Add support for pitc... Liran Alon
- [Qemu-devel] [PATCH 13/29] vmsvga: Add support for exte... Liran Alon
- [Qemu-devel] [PATCH 07/29] vmsvga: Handle SVGA_CMD_FRON... Liran Alon
- [Qemu-devel] [PATCH 14/29] vmsvga: Setup interrupt pin Liran Alon
- [Qemu-devel] [PATCH 29/29] vmsvga: Don't allow setting ... Liran Alon