On 8/9/18 12:33 PM, Alberto Garcia wrote:
On Thu 09 Aug 2018 12:11:37 AM CEST, Leonid Bloch wrote:
The default cache-clean-interval is set to 10 minutes, in order to lower
the overhead of the qcow2 caches (before the default was 0, i.e.
disabled).
Signed-off-by: Leonid Bloch <lbl...@janustech.com>
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -2830,7 +2830,8 @@
#
# @cache-clean-interval: clean unused entries in the L2 and refcount
# caches. The interval is in seconds. The default
value
-# is 0 and it disables this feature (since 2.5)
+# is 600. Setting 0 disables this feature. (since 2.5)
+#
It should be "Setting it to 0 ...".
How about:
"... is 600 (0 disables this feature). (since 2.5)"?
... To avoid the extra line. That's why I skipped the "it to" as well.
Alternatively, maybe we can skip the defaults altogether in this file,
just as with all the other qcow2 options there?
Leonid.
With that corrected,
Reviewed-by: Alberto Garcia <be...@igalia.com>
Berto
