On 07/08/18 20:45, Eduardo Habkost wrote:
Is this sufficient, or are the compat properties supposed to be versioned
according to the QEMU machine version?
I never saw compat_properties being used for non-versioned
machines, but it should work for this use case as well.
But, I'm not sure this is the best option. If the machine type
is not versioned, you can simply manually set the device property
to the desired value when creating the device inside your machine
init function. See how the "data_width" and "dma_enabled"
properties are set by existing machines, for an example.
After some more digging, I can see that you are right and that we can
actually get away with a standard qdev property for the fw_cfg device
rather than a machine property after all - it's just that I need to
convert both machines away from using the old fw_cfg_init() functions
first. I'll send over what I have shortly.
ATB,
Mark.
