On 07/30/2018 12:11 PM, Aleksandar Markovic wrote: > From: Aleksandar Markovic <amarko...@wavecomp.com> > > Mark switch fallthroughs with comments, in cases fallthroughs > are intentional. > > The comments "/* fall through */" are interpreted by compilers and > other tools, and they will not issue warnings in such cases. For gcc, > the warning is turnend on by -Wimplicit-fallthrough. With this patch, > there will be no such warnings in target/mips directory. If such > warning appears in future, it should be checked if it is intentional, > and, if yes, marked with a comment similar to those from this patch. > > The comment must be just before next "case", otherwise gcc won't > understand it. > > Signed-off-by: Aleksandar Markovic <amarko...@wavecomp.com> > Signed-off-by: Stefan Markovic <smarko...@wavecomp.com> > --- > target/mips/translate.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-)
Reviewed-by: Richard Henderson <richard.hender...@linaro.org> r~
