On 25 July 2018 at 09:59, Stefan Hajnoczi <stefa...@redhat.com> wrote:
> The TYPE_ARMV7M class is really a container for an ARM M Profile CPU,
> NVIC, and related pieces. It can also be used for ARMv6-M and ARMv8-M.
> Rename the class since it is not exclusive to ARMv7-M.
>
> Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com>
> ---
> hw/arm/Makefile.objs | 1 -
> include/hw/arm/{armv7m.h => arm-m-profile.h} | 37 ++-
> include/hw/arm/iotkit.h | 4 +-
> include/hw/arm/msf2-soc.h | 4 +-
> include/hw/arm/stm32f205_soc.h | 4 +-
> hw/arm/arm-m-profile.c | 271 +++++++++++++++++
> hw/arm/armv7m.c | 290 -------------------
> hw/arm/iotkit.c | 2 +-
> hw/arm/mps2-tz.c | 1 -
> hw/arm/mps2.c | 6 +-
> hw/arm/msf2-soc.c | 2 +-
> hw/arm/stellaris.c | 4 +-
> hw/arm/stm32f205_soc.c | 2 +-
> 13 files changed, 313 insertions(+), 315 deletions(-)
> rename include/hw/arm/{armv7m.h => arm-m-profile.h} (65%)
> delete mode 100644 hw/arm/armv7m.c
It would be nice if this rename showed up in the patch as
a rename, rather than a "delete everything and have a new one"...
Reviewing this is going to be painful enough to make me wonder
whether it really matters that we call this "m-profile" rather
than "v7m" (we have a lot of places that use 'v7m' as a somewhat
inaccurate name for "M profile" anyway, including a bunch
of new code I wrote that's really v8m related.)
thanks
-- PMM
