On 07/27/2018 12:18 PM, Thomas Huth wrote:
On 07/27/2018 05:13 PM, Markus Armbruster wrote:
qtest_init() creates a new QTestState, and leaves @global_qtest alone.
qtest_start() additionally assigns it to @global_qtest, but
qtest_startf() additionall sets assigns NULL to @global_qtest. This
makes no sense. Replace it by qtest_initf() that works like
qtest_init(), i.e. leaves @global_qtest alone.
FWIW, the original idea was to get rid of global_qtest, and then to
remove qtest_init instead:
https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg02723.html
Not sure whether Eric is still working on these patches, though.
As pointed out in the cover letter, there are still some good things to
salvage from my series, but at this point, it's been closer to a year
since I last posted anything, so it is just as easy for me to
rebase/rework from scratch for salvaging the good things, after this
series lands.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
