On 07/24/2018 05:26 AM, Peter Maydell wrote: > On 15 July 2018 at 01:37, Richard Henderson <r...@twiddle.net> wrote: >> On 07/13/2018 10:09 AM, Peter Maydell wrote: >>> @@ -939,29 +935,21 @@ tb_page_addr_t get_page_addr_code(CPUArchState *env, >>> target_ulong addr) >>> } >>> assert(tlb_hit(env->tlb_table[mmu_idx][index].addr_code, addr)); >>> } >>> + assert(tlb_hit(env->tlb_table[mmu_idx][index].addr_code, addr)); >> >> Don't duplicate the assert; just move it. Otherwise, >> >> Reviewed-by: Richard Henderson <richard.hender...@linaro.org> > > I propose to put this patch into my target-arm.for-3.1 branch > (with the duplicated assert deleted), unless you have another > preference.
That's fine by me. r~