On Thu, Jul 19, 2018 at 12:59 AM, Thomas Huth <th...@redhat.com> wrote: > On 18.07.2018 23:31, Alistair Francis wrote: >> On Wed, Jul 18, 2018 at 12:22 AM, Thomas Huth <th...@redhat.com> wrote: >>> On 17.07.2018 22:27, Alistair Francis wrote: >>>> This is based on Thomas's work fixing introspection problems [1] and >>>> applied to the RISC-V port. >>>> >>>> 1: https://lists.gnu.org/archive/html/qemu-devel/2018-07/msg03261.html >>>> >>>> Alistair Francis (5): >>>> sifive_e: Fix crash when introspecting the device >>>> sifive_u: Fix crash when introspecting the device >>>> virt: Fix crash when introspecting the device >>>> riscv_hart: Fix crash when introspecting the device >>>> spike: Fix crash when introspecting the device >>>> >>>> hw/riscv/riscv_hart.c | 7 +++---- >>>> hw/riscv/sifive_e.c | 12 ++++++------ >>>> hw/riscv/sifive_u.c | 15 +++++++-------- >>>> hw/riscv/spike.c | 10 ++++------ >>>> hw/riscv/virt.c | 5 ++--- >>>> 5 files changed, 22 insertions(+), 27 deletions(-) >>> >>> That's interesting, these issues did not appear in my tests (modified >>> tests/device-introspect-test.c with hmp("info qtree")). Likely because >>> device-introspect-test only checks with the "none" machine ==> one more >>> reason to test here with all machines, too (I suggested such a patch a >>> couple of months ago) ... >> >> What happened to the patch? More tests would be super handy. > > It was only a RFC since at that point in time, there were lots of other > crashes, so it could not be merged yet: > > http://lists.gnu.org/archive/html/qemu-devel/2018-03/msg05033.html > > I think the other crashes are now fixed, too, so we could consider this > again. I'll put it on my TODO list to respin it for 3.1 ...
It looks super useful! I'll use this to test the RISC-V stuff a bit more as well. Alistair > > Thomas
