* Collin Walling (wall...@linux.ibm.com) wrote:
> When typing 'help' followed by an unknown command, QEMU will
> not print anything to the command line to let the user know
> they typed a bad command. Let's fix this by printing a message
> to the monitor when this happens. For example:
>
> (qemu) help xyz
> unknown command: 'xyz'
>
> Reported-by: Stefan Zimmermann <s...@linux.ibm.com>
> Signed-off-by: Collin Walling <wall...@linux.ibm.com>
> ---
> monitor.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/monitor.c b/monitor.c
> index 7af1f18..7942f9f 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -1034,9 +1034,12 @@ static void help_cmd_dump(Monitor *mon, const
> mon_cmd_t *cmds,
> } else {
> help_cmd_dump_one(mon, cmd, args, arg_index);
> }
> - break;
> + return;
> }
> }
> +
> + /* Entry not found */
> + monitor_printf(mon, "unknown command: '%s'\n", args[arg_index]);
Thanks, that does suffer from a similar bug to the one you fixed a
few months back in 317c52cc6aa0d ('monitor: report entirety of hmp
command on error'):
(qemu) help foo
unknown command: 'foo'
(qemu) help info foo
unknown command: 'foo'
Dave
(And yes, please cc me, otherwise I can miss them)
> }
>
> static void help_cmd(Monitor *mon, const char *name)
> --
> 2.7.4
>
>
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
