Re: [Qemu-devel] [PATCH for-3.0 1/2] accel/tcg: Use correct test when looking in victim TLB for code

[Richard Henderson]

On 07/13/2018 07:16 AM, Peter Maydell wrote:
> @@ -967,7 +967,7 @@ tb_page_addr_t get_page_addr_code(CPUArchState *env, 
> target_ulong addr)
>      index = (addr >> TARGET_PAGE_BITS) & (CPU_TLB_SIZE - 1);
>      mmu_idx = cpu_mmu_index(env, true);
>      if (unlikely(!tlb_hit(env->tlb_table[mmu_idx][index].addr_code, addr))) {
> -        if (!VICTIM_TLB_HIT(addr_read, addr)) {
> +        if (!VICTIM_TLB_HIT(addr_code, addr)) {
Oh geez.

Reviewed-by: Richard Henderson <richard.hender...@linaro.org>


r~