On 11/07/2018 22:23, Eduardo Habkost wrote: > On Wed, Jul 11, 2018 at 10:16:42PM +0200, Paolo Bonzini wrote: >> On 11/07/2018 20:30, Eduardo Habkost wrote: >>>> The theoretical behavior should be: >>> It's not clear below where you expect >>> qdev_set_parent_bus(..., sysbus_get_default()) >>> to be called (if it should be called at all). >>> >>> I don't know where it should be called, but I'm absolutely sure >>> instance_init is not the right place. >> >> I think instance_init is fine to call qdev_set_parent_bus on contained >> devices. Why do you say it's not? > > Because object_unref(object_new(...)) is not supposed to affect > QEMU global state at all.
It should not affect it. Any changes to the global state done by instance_init are immediately undone when object_unref destroys the child properties of the object. Thanks, Paolo
