On Tue, Jul 10, 2018 at 5:10 PM, Alistair Francis <alistai...@gmail.com> wrote: > On Mon, Jul 9, 2018 at 6:54 PM, Michael Clark <m...@sifive.com> wrote: >> >> >> On Tue, 10 Jul 2018 at 12:29 PM, Alistair Francis <alistair.fran...@wdc.com> >> wrote: >>> >>> Add build time support for the VirtIO block device. This allows us to >>> attach a drive using the virtio-blk-device. >> >> >> I’m not sure what has changed in master, but VirtIO block and net for both >> softmmu-riscv32 and softmmu-riscv64 were previously building by default and >> working. Perhaps i’ve missed some patches that split up VirtIO support into >> more granular config options. > > It just occurred to me that this patch might not be required. Someone > my last patch series had a conflict that results in removing the virt > include in the default configs. I suspect this patch can be dropped.
Yep, no longer required. Alistair > > Alistair > >> >> In any case, we should enable both CONFIG_VIRTIO_NET and CONFIG_VIRTIO_BLK >> for both riscv32 and riscv64 as these were working in QEMU 2.12. There are >> folk using the “virt” machine for riscv32 Linux. >> >> Thanks, at least I know what to expect when I rebase my patch queue against >> master and of course make a PR for the reviewed patches... >> >> I’m not sure of the soft-freeze date but the bulk of the patches are the >> same ones that were posted about a month ago... I also have several patches >> that are not yet on the list... >> >> Vectored interrupts. Trap tracing. More spec wording clarifications >> regarding load reservations and interrupts: >> >> - >> https://github.com/riscv/riscv-qemu/commits/qemu-2.13-for-upstream >> >> Michael >> >>> Signed-off-by: Alistair Francis <alistair.fran...@wdc.com> >>> --- >>> default-configs/riscv64-softmmu.mak | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/default-configs/riscv64-softmmu.mak >>> b/default-configs/riscv64-softmmu.mak >>> index 35e74bebe9..8790f3b115 100644 >>> --- a/default-configs/riscv64-softmmu.mak >>> +++ b/default-configs/riscv64-softmmu.mak >>> @@ -12,3 +12,5 @@ CONFIG_PCI_XILINX=y >>> >>> CONFIG_VGA=y >>> CONFIG_VGA_PCI=y >>> + >>> +CONFIG_VIRTIO_BLK=y >>> -- >>> 2.17.1 >>> >>
