On 07/06/2018 01:08 PM, Peter Maydell wrote:
> On 6 July 2018 at 16:51, Philippe Mathieu-Daudé <f4...@amsat.org> wrote:
>> This can still be reported using the "-d unimp" command line option.
>>
>> Code change produced with:
>>
>> git ls-files linux-user | \
>> xargs sed -i -E 's/fprintf\(stderr,\s?(".*not
>> implemented\\n")\);/qemu_log_mask(LOG_UNIMP, \1);/g'
>>
>> Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org>
>> ---
>> linux-user/cris/signal.c | 4 ++--
>> linux-user/microblaze/signal.c | 4 ++--
>> linux-user/nios2/signal.c | 2 +-
>> linux-user/sparc/signal.c | 4 ++--
>> 4 files changed, 7 insertions(+), 7 deletions(-)
>>
>> diff --git a/linux-user/cris/signal.c b/linux-user/cris/signal.c
>> index 0b405247cf..1e02194377 100644
>> --- a/linux-user/cris/signal.c
>> +++ b/linux-user/cris/signal.c
>> @@ -146,7 +146,7 @@ void setup_rt_frame(int sig, struct target_sigaction *ka,
>> target_siginfo_t *info,
>> target_sigset_t *set, CPUCRISState *env)
>> {
>> - fprintf(stderr, "CRIS setup_rt_frame: not implemented\n");
>> + qemu_log_mask(LOG_UNIMP, "setup_rt_frame: not implemented\n");
>
> Your regex seems to have gone a bit awry here, because it's lost
> the "CRIS" part of the string (similarly below).
Oh I deliberately dropped it when using 'git add -p' after the regex
because I noticed neither nios2 nor sparc arch were using it, and I
don't think this is a relevant information.
Do you prefer I restore them, I reword the commit message, or even add
similar description for the nios2/sparc?
Thanks,
Phil.
