On 06/07/2018 03:18, David Gibson wrote: >> Ok, but why would it even fail? Maybe it's not this case, but even if >> it's not fatal for the OS, generating different device trees silently >> seems like a recipe for Heisenbugs. > Yes, quite. Especially since the most likely errors I can see here > would actually indicate something has already gone horribly wrong with > the device tree construction, so a missing clock-frequency is the > least of our troubles. > > I think using _FDT() here would be a better approach.
Or qemu_fdt_setprop_cell, which is there exactly for this reason. Volunteers needed to report it in checkpatch! :) Paolo
signature.asc
Description: OpenPGP digital signature
