On Mon, Jul 02, 2018 at 09:42:49AM +0200, Sebastian Bauer wrote: > Am 2018-07-02 07:22, schrieb David Gibson: > > And now unapplied, since it breaks make check all over the place for > > ppc64-softmmu. > > > > Please folks, running an all-targets make check is really the > > *minimum* bar for testing before posting a patch for inclusion. > > Okay, will do next time. Sorry for the inconvenience. > > But I can't find anything about this procedure in the Wiki. Maybe it would > be a good idea to add this info for people that are new, or if it is written > somewhere it should be linked from here: > https://wiki.qemu.org/Contribute/SubmitAPatch as this is most likely the > starting point for new contributors.
That's a good point. At the moment there's really nothing there about testing your patch before submission, which is a bit of an ommission. [1] covers a bunch of ways that qemu can be tested, but doesn't give much idea about priority. +eblake, you seem to have made more mods than anyone else to the SubmitAPatch wiki page. What do you think about adding a subsection about what basic testing you should do before posting a patch? [1] https://wiki.qemu.org/Testing -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
