On Fri, 29 Jun 2018 19:05:20 +0200 David Hildenbrand <da...@redhat.com> wrote:
> tcg_s390_tod_updated() is always called with the iothread being locked > (e.g. from S390TODClass->set() e.g. via HELPER(sck) or on incomming s/incomming/incoming/ > migration). The helper we call takes the lock itself - bad. > > Let's change that by factoring out updating the ckc timer. This now looks > much nicer than having to call a helper from another function. > > While touch it we also make sure that env->ckc is updated even if the new s/touch/touching/ > value is -1ULL, for now it would not have been modified in that case. > > Reported-by: Christian Borntraeger <borntrae...@de.ibm.com> > Signed-off-by: David Hildenbrand <da...@redhat.com> > --- > > This survives my tests and the iotests Christian mentioned. OK, this will the last patch (I guess) before I send my final 3.0 pull request. > > target/s390x/misc_helper.c | 26 ++++++++++++++++---------- > 1 file changed, 16 insertions(+), 10 deletions(-) Thanks, applied.
