Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180625203559.21370-1-laur...@vivier.eu
Subject: [Qemu-devel] [PATCH 0/1] target/m68k: correctly disassemble move16
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
ce9f09fe63 target/m68k: correctly disassemble move16
=== OUTPUT BEGIN ===
Checking PATCH 1/1: target/m68k: correctly disassemble move16...
ERROR: that open brace { should be on the previous line
#30: FILE: disas/m68k.c:2021:
+ if (*d == '\0')
+ {
ERROR: suspect code indent for conditional statements (10, 14)
#30: FILE: disas/m68k.c:2021:
+ if (*d == '\0')
+ {
ERROR: that open brace { should be on the previous line
#32: FILE: disas/m68k.c:2023:
+ for (d = opc->args; *d; d += 2)
+ {
ERROR: suspect code indent for conditional statements (14, 18)
#32: FILE: disas/m68k.c:2023:
+ for (d = opc->args; *d; d += 2)
+ {
ERROR: that open brace { should be on the previous line
#34: FILE: disas/m68k.c:2025:
+ if (d[0] == 'I')
+ {
ERROR: suspect code indent for conditional statements (18, 22)
#34: FILE: disas/m68k.c:2025:
+ if (d[0] == 'I')
+ {
ERROR: space prohibited between function name and open parenthesis '('
#36: FILE: disas/m68k.c:2027:
+ val = fetch_arg (buffer, 'd', 3, info);
ERROR: braces {} are necessary for all arms of this statement
#37: FILE: disas/m68k.c:2028:
+ if (val != 1)
[...]
total: 8 errors, 0 warnings, 20 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-de...@redhat.com
