On 06/25/2018 05:42 AM, Philippe Mathieu-Daudé wrote: > It eases code review, unit is explicit. > > Patch generated using: > > $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ > > and modified manually. > > Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> > --- > hw/smbios/smbios.c | 15 ++++++--------- > 1 file changed, 6 insertions(+), 9 deletions(-)
Reviewed-by: Richard Henderson <richard.hender...@linaro.org> > @@ -640,7 +637,7 @@ static void smbios_build_type_16_table(unsigned dimm_cnt) > t->location = 0x01; /* Other */ > t->use = 0x03; /* System memory */ > t->error_correction = 0x06; /* Multi-bit ECC (for Microsoft, per > SeaBIOS) */ > - size_kb = QEMU_ALIGN_UP(ram_size, ONE_KB) / ONE_KB; > + size_kb = QEMU_ALIGN_UP(ram_size, KiB) / KiB; Perhaps for a different patch set, but DIV_ROUND_UP. r~
