On 06/26/2018 09:50 AM, Vladimir Sementsov-Ogievskiy wrote:
> Hi all.
>
> To continue talk about correct loading of persistent bitmaps here is
> a patch (04), with some surrounding.
>
> Patch 04 contains new (and I hope, more clean) logic of bitmaps
> loading/inactivation/invalidation/migration, with the whole description.
> Let me not duplicate it here, you can safely start reading from 04
> commit message and internal big comment.
>
> Vladimir Sementsov-Ogievskiy (6):
> iotests: 169: drop deprecated 'autoload' parameter
> block/qcow2: improve error message in qcow2_inactivate
> bloc/qcow2: drop dirty_bitmaps_loaded state variable
> dirty-bitmaps: clean-up bitmaps loading and migration logic
> iotests: improve 169
> iotests: 169: add cases for source vm resuming
>
> block/qcow2.h | 1 -
> include/block/dirty-bitmap.h | 2 +-
> block.c | 11 ++++--
> block/dirty-bitmap.c | 36 +++++++-----------
> block/qcow2-bitmap.c | 16 ++++++++
> block/qcow2.c | 86
> ++++++++++++++++++++++++++++++++----------
> migration/block-dirty-bitmap.c | 10 ++++-
> tests/qemu-iotests/169 | 70 +++++++++++++++++++++++++++++++++-
> tests/qemu-iotests/169.out | 4 +-
> 9 files changed, 182 insertions(+), 54 deletions(-)
>
Does this effectively supersede "[PATCH] block/qcow2: fix logic around
dirty_bitmaps_loaded"?
(I'll review it in just a moment, regardless, but I'm trying to keep my
notes tidy.)
--js
