On 26.06.2018 08:09, Gerd Hoffmann wrote: > This makes sure the regions are properly cleaned when unplugging -device > seconday-vga. > > Reported-by: Thomas Huth <th...@redhat.com> > Signed-off-by: Gerd Hoffmann <kra...@redhat.com> > --- > hw/display/vga_int.h | 1 + > hw/display/vga-pci.c | 11 ++++++----- > hw/display/virtio-vga.c | 2 +- > 3 files changed, 8 insertions(+), 6 deletions(-)
Thanks, this fixes the issue indeed! Without this patch: $ valgrind mips-softmmu/qemu-system-mips -accel qtest -monitor stdio [...] (qemu) device_add secondary-vga Unsupported bus. Bus doesn't have property 'acpi-pcihp-bsel' set (qemu) dump-guest-memory /dev/null 0 4096 ==8407== Invalid read of size 8 ==8407== at 0x6B0DA5: object_dynamic_cast (object.c:613) ==8407== by 0x6B0DA5: object_resolve_abs_path (object.c:1721) ==8407== by 0x6B0E00: object_resolve_partial_path (object.c:1745) ==8407== by 0x6B0E62: object_resolve_partial_path (object.c:1755) [...] With this patch applied, the problem is gone. Tested-by: Thomas Huth <th...@redhat.com> Reviewed-by: Thomas Huth <th...@redhat.com>
