On 06/20/2018 05:06 AM, Yongbok Kim wrote:
> case NM_P_ROTX:
> + if (rt != 0) {
> + TCGv t0 = tcg_temp_new();
> + TCGv_i32 shift = tcg_const_i32(extract32(ctx->opcode, 0, 5));
> + TCGv_i32 shiftx = tcg_const_i32(extract32(ctx->opcode, 7, 4)
> + << 1);
> + TCGv_i32 stripe = tcg_const_i32((ctx->opcode >> 6) & 1);
> +
> + gen_load_gpr(t0, rs);
> + gen_helper_rotx(cpu_gpr[rt], t0, shift, shiftx, stripe);
> + tcg_temp_free(t0);
> +
> + tcg_temp_free_i32(shift);
> + tcg_temp_free_i32(shiftx);
> + tcg_temp_free_i32(stripe);
> + }
It would be worth your while to recognize the special case of BYTEREVW.
But otherwise
Reviewed-by: Richard Henderson <richard.hender...@linaro.org>
r~
