On Thu, Jun 21, 2018 at 2:33 PM, Tiwei Bie <tiwei....@intel.com> wrote:
> On Mon, Jun 18, 2018 at 06:17:07PM +0200, Marc-André Lureau wrote:
> [...]
>> diff --git a/hw/virtio/vhost-stub.c b/hw/virtio/vhost-stub.c
>> index 049089b5e2..323dfcc46a 100644
>> --- a/hw/virtio/vhost-stub.c
>> +++ b/hw/virtio/vhost-stub.c
>> @@ -7,7 +7,7 @@ bool vhost_has_free_slot(void)
>> return true;
>> }
>>
>> -VhostUserState *vhost_user_init(void)
>> +bool vhost_user_init(VhostUserState *user, CharBackend *chr, Error **errp)
>> {
>> return NULL;
>
> It would be better to return false.
>
Good catch, fixed.
Except that, would you give a reviewed-by?
> Best regards,
> Tiwei Bie
>
>> }
> [...]
>
--
Marc-André Lureau
