On Thu, Jun 14, 2018 at 10:06:33AM +0200, BALATON Zoltan wrote: > On Thu, 14 Jun 2018, David Gibson wrote: > > On Thu, Jun 14, 2018 at 02:17:00AM +0200, BALATON Zoltan wrote: > > > Signed-off-by: BALATON Zoltan <bala...@eik.bme.hu> > > > > Again needs a commit message expanding on what this is and why it's > > useful. > > What else need to be explained apart from that SM501 has an i2c part which > is used to access EDID info of attached monitor. But this is what the commit > title already says. This patch implements that so far not emulated part of > the chip.
In this case it would be sufficient just to say the same thing, but in
a less compressed form than the subject line. e.g.
| The sm501 controller includes an i2c slave from which the monitor's
| EDID information can be read. This wasn't yet implemented in qemu,
| so this patch adds it.
|
| (The sm501 part is used only by the SH4 and PPC sam460ex machine
| types in qemu)
>
> > [snip]
> > > static const VMStateDescription vmstate_sm501_sysbus = {
> > > .name = TYPE_SYSBUS_SM501,
> > > - .version_id = 1,
> > > - .minimum_version_id = 1,
> > > + .version_id = 2,
> > > + .minimum_version_id = 2,
> > > .fields = (VMStateField[]) {
> > > VMSTATE_STRUCT(state, SM501SysBusState, 1,
> > > vmstate_sm501_state, SM501State),
> >
> > Additionally, since you're changing the migration stream, you need to
> > point out that this is not used in any machine types which support
> > cross-version migration.
>
> AFAIK it is only used in SH4 and PPC sam460ex.
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
