On Wed, Jun 13, 2018 at 11:14:57AM +0200, Cédric Le Goater wrote:
> >> index 13ad7d9e04..efb68226bb 100644
> >> --- a/hw/ppc/pnv_core.c
> >> +++ b/hw/ppc/pnv_core.c
> >> @@ -173,6 +173,9 @@ static void pnv_core_realize(DeviceState *dev, Error
> >> **errp)
> >>
> >> snprintf(name, sizeof(name), "thread[%d]", i);
> >> object_property_add_child(OBJECT(pc), name, obj, &local_err);
> >> + if (local_err) {
> >> + goto err;
> >> + }
> >> object_property_add_alias(obj, "core-pir", OBJECT(pc),
> >> "pir", &local_err);
> >> if (local_err) {
> >
> > Hmm... the current error path seems to assume failures to be
> > caused by object_property_add_child(). It hence unparents the
> > previously parented CPUs, but not the current one. So we'll
> > miss one call to object_unparent() if object_property_add_alias()
> > fails.
>
> yes, let's just put NULL or &error_abort instead.
Yeah, good idea, I'll change it in a new spin.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
