On 06/11/2018 02:56 PM, Eduardo Habkost wrote:
The newline was removed by commit c97d6d2c, and broke -help output:

-help output is not supposed to be parsed by machine, in part because of stuff like this ;)


Before this patch:

   $ qemu-system-x86_64 -help | grep smp
                   thread=single|multi (enable multi-threaded TCG)-smp [...]

After this patch:

   $ qemu-system-x86_64 -help  | grep smp
   -smp 
[cpus=]n[,maxcpus=cpus][,cores=cores][,threads=threads][,sockets=sockets]

Fixes: c97d6d2cdf97edb4aebe832fdba65d701ad7bcb6
Cc: Sergio Andres Gomez Del Real <sergio.g.delr...@gmail.com>
Signed-off-by: Eduardo Habkost <ehabk...@redhat.com>
---

But for the humans, this is a definite mistake worth fixing.

Reviewed-by: Eric Blake <ebl...@redhat.com>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Reply via email to