On 07.06.2018 14:31, no-re...@patchew.org wrote: > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Type: series > Message-id: 1528374154-14680-1-git-send-email-th...@redhat.com > Subject: [Qemu-devel] [PATCH v2 0/4] pc-bios/s390-ccw: Allow network booting > via pxelinux.cfg > > === TEST SCRIPT BEGIN === > #!/bin/bash > > BASE=base > n=1 > total=$(git log --oneline $BASE.. | wc -l) > failed=0 > > git config --local diff.renamelimit 0 > git config --local diff.renames True > git config --local diff.algorithm histogram > > commits="$(git log --format=%H --reverse $BASE..)" > for c in $commits; do > echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." > if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; > then > failed=1 > echo > fi > n=$((n+1)) > done > > exit $failed > === TEST SCRIPT END === > > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > From https://github.com/patchew-project/qemu > 5d328d7d2f..8e36d27c5a master -> master > * [new tag] > patchew/1528374154-14680-1-git-send-email-th...@redhat.com -> > patchew/1528374154-14680-1-git-send-email-th...@redhat.com > * [new tag] > patchew/1528403460-30526-1-git-send-email-gengdong...@huawei.com -> > patchew/1528403460-30526-1-git-send-email-gengdong...@huawei.com > t [tag update] > patchew/20180530180120.13355-1-richard.hender...@linaro.org -> > patchew/20180530180120.13355-1-richard.hender...@linaro.org > Switched to a new branch 'test' > 132ffa3587 pc-bios/s390-ccw/net: Try to load pxelinux.cfg file accoring to > the UUID > b3b73613ba pc-bios/s390-ccw/net: Add support for pxelinux-style config files > 699020402a pc-bios/s390-ccw/net: Update code for the latest changes in SLOF > 5dd76a9c89 roms: Update SLOF submodule to current status > > === OUTPUT BEGIN === > Checking PATCH 1/4: roms: Update SLOF submodule to current status... > Checking PATCH 2/4: pc-bios/s390-ccw/net: Update code for the latest changes > in SLOF... > Checking PATCH 3/4: pc-bios/s390-ccw/net: Add support for pxelinux-style > config files... > Checking PATCH 4/4: pc-bios/s390-ccw/net: Try to load pxelinux.cfg file > accoring to the UUID... > ERROR: space prohibited before open square bracket '[' > #57: FILE: pc-bios/s390-ccw/netmain.c:267: > + : [cc] "=d" (cc)
Patchew obviously does not know about inline assembly ... I think I prefer to keep the space here. Thomas
