On Tue, Jun 05, 2018 at 02:59:01PM -0400, John Snow wrote:
> From: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com>
>
> Add locks and remove comments about BQL accordingly to
> dirty_bitmap_mutex definition in block_int.h.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com>
> Signed-off-by: John Snow <js...@redhat.com>
Reviewed-by: Jeff Cody <jc...@redhat.com>
> ---
> block/dirty-bitmap.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c
> index 967159479d..56234257f4 100644
> --- a/block/dirty-bitmap.c
> +++ b/block/dirty-bitmap.c
> @@ -442,18 +442,20 @@ void
> bdrv_remove_persistent_dirty_bitmap(BlockDriverState *bs,
> }
> }
>
> -/* Called with BQL taken. */
> void bdrv_disable_dirty_bitmap(BdrvDirtyBitmap *bitmap)
> {
> + bdrv_dirty_bitmap_lock(bitmap);
> assert(!bdrv_dirty_bitmap_frozen(bitmap));
> bitmap->disabled = true;
> + bdrv_dirty_bitmap_unlock(bitmap);
> }
>
> -/* Called with BQL taken. */
> void bdrv_enable_dirty_bitmap(BdrvDirtyBitmap *bitmap)
> {
> + bdrv_dirty_bitmap_lock(bitmap);
> assert(!bdrv_dirty_bitmap_frozen(bitmap));
> bitmap->disabled = false;
> + bdrv_dirty_bitmap_unlock(bitmap);
> }
>
> BlockDirtyInfoList *bdrv_query_dirty_bitmaps(BlockDriverState *bs)
> --
> 2.14.3
>
>
