On 5 June 2018 at 14:54, Laurent Vivier <laur...@vivier.eu> wrote: > linux-user targets don't need them, and if we ask to build statically > linked binaries some static binaries they need are not available. > > Signed-off-by: Laurent Vivier <laur...@vivier.eu> > --- > Makefile | 2 ++ > tests/Makefile.include | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/Makefile b/Makefile > index 6d588d1f71..5f198ee4bb 100644 > --- a/Makefile > +++ b/Makefile > @@ -351,7 +351,9 @@ $(call set-vpath, $(SRC_PATH)) > > LIBS+=-lz $(LIBS_TOOLS) > > +ifeq ($(CONFIG_SOFTMMU),y) > HELPERS-$(CONFIG_LINUX) = qemu-bridge-helper$(EXESUF) > +endif
HELPERS-$(call land,$(CONFIG_SOFTMMU),$(CONFIG_LINUX)) = qemu-bridge-helper$(EXESUF) ? > ifdef BUILD_DOCS > DOCS=qemu-doc.html qemu-doc.txt qemu.1 qemu-img.1 qemu-nbd.8 qemu-ga.8 > diff --git a/tests/Makefile.include b/tests/Makefile.include > index 86f90c0cb0..adaa5274c8 100644 > --- a/tests/Makefile.include > +++ b/tests/Makefile.include > @@ -923,7 +923,9 @@ check-report.html: check-report.xml > > # Other tests > > +ifeq ($(CONFIG_SOFTMMU),y) > QEMU_IOTESTS_HELPERS-$(CONFIG_LINUX) = > tests/qemu-iotests/socket_scm_helper$(EXESUF) > +endif Do we also need to do something to ensure that the tests that use this helper don't run, or does that happen automatically? thanks -- PMM
