Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180602031629.3925-1-cont...@steffen-goertz.de
Subject: [Qemu-devel] [RFC] qapi: command category to stimulate high-level
machine devices
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
t [tag update] patchew/20180417153945.20737-1-pbonz...@redhat.com
-> patchew/20180417153945.20737-1-pbonz...@redhat.com
t [tag update]
patchew/20180601141223.26630-1-peter.mayd...@linaro.org ->
patchew/20180601141223.26630-1-peter.mayd...@linaro.org
* [new tag]
patchew/20180602031629.3925-1-cont...@steffen-goertz.de ->
patchew/20180602031629.3925-1-cont...@steffen-goertz.de
Switched to a new branch 'test'
cd5a3e2526 qapi: command category to stimulate high-level machine devices
=== OUTPUT BEGIN ===
Checking PATCH 1/1: qapi: command category to stimulate high-level machine
devices...
ERROR: "foo * bar" should be "foo *bar"
#189: FILE: hw/arm/microbit.c:19:
+ NRF51State * soc;
ERROR: line over 90 characters
#198: FILE: hw/arm/microbit.c:28:
+ object_property_add_alias(OBJECT(machine), "button-a", OBJECT(soc->nvic),
"unnamed-gpio-in[17]", &error_fatal);
ERROR: line over 90 characters
#199: FILE: hw/arm/microbit.c:29:
+ object_property_add_alias(OBJECT(machine), "button-b", OBJECT(soc->nvic),
"unnamed-gpio-in[26]", &error_fatal);
ERROR: trailing whitespace
#232: FILE: qapi/stimulate.json:15:
+ $
ERROR: suspicious ; after while (0)
#275: FILE: stimulate.c:28:
+} while (0);
total: 5 errors, 0 warnings, 192 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-de...@redhat.com
