Hi Peter, > > On 1 June 2018 at 14:17, gengdongjiu <gengdong...@huawei.com> wrote: > > Hi Peter, > >> This series failed build test on s390x host. Please find the details below. > > >> /var/tmp/patchew-tester-tmp-hwsn3wsl/src/hw/display/virtio-gpu-3d.c: In > >> function ‘virgl_cmd_get_capset_info’: > >> /var/tmp/patchew-tester-tmp-hwsn3wsl/src/hw/display/virtio-gpu-3d.c:3 > >> 66:26: error: ‘VIRTIO_GPU_CAPSET_VIRGL2’ undeclared (first use in this > >> function); did you mean ‘VIRTIO_GPU_CAPSET_VIRGL’? > >> resp.capset_id = VIRTIO_GPU_CAPSET_VIRGL2; > >> ^~~~~~~~~~~~~~~~~~~~~~~~ > >> VIRTIO_GPU_CAPSET_VIRGL > >> /var/tmp/patchew-tester-tmp-hwsn3wsl/src/hw/display/virtio-gpu-3d.c:3 > >> 66:26: note: each undeclared identifier is reported only once for > >> each function it appears in > >> /var/tmp/patchew-tester-tmp-hwsn3wsl/src/hw/display/virtio-gpu-3d.c: In > >> function ‘virtio_gpu_virgl_get_num_capsets’: > >> /var/tmp/patchew-tester-tmp-hwsn3wsl/src/hw/display/virtio-gpu-3d.c:6 > >> 46:32: error: ‘VIRTIO_GPU_CAPSET_VIRGL2’ undeclared (first use in this > >> function); did you mean ‘VIRTIO_GPU_CAPSET_VIRGL’? > > > This build failure is due to kernel missing the definition of > > "VIRTIO_GPU_CAPSET_VIRGL2", I sync the mainline kernel tree header file to > > the mainline QEMU using the scripts[1], So happen this > failure, It does not related with myself patch, so can I discard the patch > [1] or add the ‘VIRTIO_GPU_CAPSET_VIRGL2’ definition to > mainline kernel tree? > > This is a known issue with the kernel headers (hopefully somebody will fix > them). There are several nits and also bugs in the update-headers > script that I sent a patchset to fix recently: > https://lists.gnu.org/archive/html/qemu-devel/2018-05/msg05803.html > > You should wait for that to get into master (it is in Paolo's most recent > patchset but that has an issue with a different patch, so is waiting on > Paolo to do a respin). Then you can base on that. At that point a simple > script update should work fine (if you need anything in rc7 that > wasn't in rc6).
Ok, got it. Thanks a lot for the explanation, I will wait for your patch[1] merge into master and based on it. [1] https://lists.gnu.org/archive/html/qemu-devel/2018-05/msg05803.html > > thanks > -- PMM
