Hi Shannon, On 05/31/2018 03:42 AM, Shannon Zhao wrote: > > > On 2018/5/31 0:18, Laszlo Ersek wrote: >> + vms->highmem_ecam &= vms->highmem && (!firmware_loaded || aarch64); >>> + > Does it need a info log here to tell user that even though you enable > the highmem_ecam but due to some other reasons it's disabled. > > Also, if user enables highmem_ecam but finally it can't enable, does it > need to error out?
highmem_ecam is not a user settable option. highmem is. highmem_ecam is computed based on the machine type capability to support this feature, the fact highmem is set and we don't have an aarch32 FW being used. Thanks Eric > > Thanks, >
