On 29 May 2018 at 15:58, Cédric Le Goater <c...@kaod.org> wrote: > Hello, > > Here is a couple of enhancements and fixes for the ftgmac100 NIC used > on the Aspeed SoC. It includes VLAN and multicast support. > > Following is an assorted set of changes for the NC-SI backend also > used on the Aspeed SoC when soldered on OpenPOWER boards. These fix a > few problems found when running OpenBMC on aspeed QEMU machines. > > Thanks, > > Cédric. > > Cédric Le Goater (6): > ftgmac100: compute maximum frame size depending on the protocol > ftgmac100: add IEEE 802.1Q VLAN support > net/ftgmac100: fix multicast hash routine > slirp/ncsi: fix "Get Version ID" payload length > slirp/ncsi: add a "Get Parameter" response > slirp/ncsi: add checksum support
I tested these with -M palmetto-bmc and linux-next as the guest, and networking appeared to work fine. For the series: Tested-by: Joel Stanley <j...@jms.id.au> One question I had. I get these messages on boot: [ 1.184472] ftgmac100 1e660000.ethernet: Read MAC address 52:54:00:12:34:56 from chip [ 1.184751] ftgmac100 1e660000.ethernet: Using NCSI interface [ 1.197107] ftgmac100 1e660000.ethernet eth0: irq 19, mapped at b30b8905 [ 1.904237] ftgmac100 1e660000.ethernet eth0: NCSI: Handler for packet type 0x82 returned -19 [ 1.905682] ftgmac100 1e660000.ethernet eth0: NCSI: Handler for packet type 0x82 returned -19 [ 1.905943] ftgmac100 1e660000.ethernet eth0: NCSI: Handler for packet type 0x82 returned -19 [ 1.906182] ftgmac100 1e660000.ethernet eth0: NCSI: Handler for packet type 0x82 returned -19 [ 1.906415] ftgmac100 1e660000.ethernet eth0: NCSI: Handler for packet type 0x82 returned -19 [ 1.906643] ftgmac100 1e660000.ethernet eth0: NCSI: Handler for packet type 0x82 returned -19 [ 1.906873] ftgmac100 1e660000.ethernet eth0: NCSI: Handler for packet type 0x82 returned -19 [ 1.907103] ftgmac100 1e660000.ethernet eth0: NCSI: Handler for packet type 0x82 returned -19 [ 2.024094] ftgmac100 1e660000.ethernet eth0: NCSI: configuring channel 0 [ 2.025428] ftgmac100 1e660000.ethernet eth0: NCSI: channel 0 config done [ 2.025544] ftgmac100 1e660000.ethernet eth0: NCSI: No more channels to process [ 2.025608] ftgmac100 1e660000.ethernet eth0: NCSI interface up Comparing to hardware, I see: [ 4.071159] ftgmac100 1e660000.ethernet: Read MAC address 98:be:94:83:00:ad from chip [ 4.079024] ftgmac100 1e660000.ethernet: Using NCSI interface [ 4.085976] ftgmac100 1e660000.ethernet eth0: irq 19, mapped at a0963000 [ 40.670099] ftgmac100 1e660000.ethernet eth0: NCSI: Handler for packet type 0x82 returned -19 [ 43.852036] ftgmac100 1e660000.ethernet eth0: NCSI: configuring channel 1 [ 43.877060] ftgmac100 1e660000.ethernet eth0: NCSI: channel 1 config done [ 43.877093] ftgmac100 1e660000.ethernet eth0: NCSI: No more channels to process [ 43.877112] ftgmac100 1e660000.ethernet eth0: NCSI interface up Is it expected that we get multiple ENODEVs for packet type 0x82 in qemu? Cheers, Joel
