On 2018-05-25 18:33, Kevin Wolf wrote: > This rewrites the test case 212 to work with the new x-blockdev-create > job rather than the old synchronous version of the command. > > All of the test cases stay the same as before, but in order to be able > to implement proper job handling, the test case is rewritten in Python. > > Signed-off-by: Kevin Wolf <kw...@redhat.com> > --- > tests/qemu-iotests/212 | 483 > +++++++++++++++++---------------------------- > tests/qemu-iotests/212.out | 181 ++++++++++------- > tests/qemu-iotests/group | 2 +- > 3 files changed, 290 insertions(+), 376 deletions(-) > > diff --git a/tests/qemu-iotests/212 b/tests/qemu-iotests/212 > index e5a1ba77ce..5ac4947b82 100755 > --- a/tests/qemu-iotests/212 > +++ b/tests/qemu-iotests/212
[...]
> +import iotests
> +from iotests import imgfmt
> +
> +iotests.verify_image_format(supported_fmts=['parallels'])
> +iotests.verify_protocol(supported=['file'])
> +
> +def blockdev_create(vm, options):
> + result = vm.qmp_log('x-blockdev-create', job_id='job0', options=options)
> +
> + if 'return' in result:
> + assert result['return'] == {}
> + vm.run_job('job0')
> + iotests.log("")
> +
> +with iotests.FilePath('t.vdi') as disk_path, \
't.vdi', are you sure about that? ;-)
(You thought I wouldn't read the boiler plate anymore, didn't you? Ha!)
With that fixed:
Reviewed-by: Max Reitz <mre...@redhat.com>
signature.asc
Description: OpenPGP digital signature
