On 05/28/2018 08:27 PM, Philippe Mathieu-Daudé wrote:
I forgot to add this commit description:
"block/nvme.h" does not require any declaration of "qemu/cutils.h".
Simplify dependencies by directly include it in the source file
where the declarations are used.
> Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org>
> Reviewed-by: Thomas Huth <th...@redhat.com>
> ---
> hw/block/nvme.h | 1 -
> hw/block/nvme.c | 1 +
> 2 files changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/block/nvme.h b/hw/block/nvme.h
> index 8f3981121d..cabcf20c32 100644
> --- a/hw/block/nvme.h
> +++ b/hw/block/nvme.h
> @@ -1,6 +1,5 @@
> #ifndef HW_NVME_H
> #define HW_NVME_H
> -#include "qemu/cutils.h"
> #include "block/nvme.h"
>
> typedef struct NvmeAsyncEvent {
> diff --git a/hw/block/nvme.c b/hw/block/nvme.c
> index 85d2406400..811084b6a7 100644
> --- a/hw/block/nvme.c
> +++ b/hw/block/nvme.c
> @@ -35,6 +35,7 @@
> #include "sysemu/block-backend.h"
>
> #include "qemu/log.h"
> +#include "qemu/cutils.h"
> #include "trace.h"
> #include "nvme.h"
>
>
