On Sat, 26 May 2018 01:23:15 -0400 k...@juliacomputing.com wrote: > From: Keno Fischer <k...@alumni.harvard.edu> > > Signed-off-by: Keno Fischer <k...@juliacomputing.com> > --- > Makefile.objs | 1 + > configure | 23 +++++++++++++++-------- > 2 files changed, 16 insertions(+), 8 deletions(-) > > diff --git a/Makefile.objs b/Makefile.objs > index c6c3554..a2245c9 100644 > --- a/Makefile.objs > +++ b/Makefile.objs > @@ -104,6 +104,7 @@ common-obj-$(CONFIG_WIN32) += os-win32.o > common-obj-$(CONFIG_POSIX) += os-posix.o > > common-obj-$(CONFIG_LINUX) += fsdev/ > +common-obj-$(CONFIG_DARWIN) += fsdev/ > > common-obj-y += migration/ > > diff --git a/configure b/configure > index a8498ab..eb7328c 100755 > --- a/configure > +++ b/configure > @@ -5535,16 +5535,27 @@ if test "$want_tools" = "yes" ; then > fi > fi > if test "$softmmu" = yes ; then > - if test "$linux" = yes; then > - if test "$virtfs" != no && test "$cap" = yes && test "$attr" = yes ; then > + if test "$virtfs" != no; then > + if test "$linux" = yes; then > + if test "$cap" = yes && test "$attr" = yes ; then > + virtfs=yes > + tools="$tools fsdev/virtfs-proxy-helper\$(EXESUF)" > + else > + if test "$virtfs" = yes; then > + error_exit "VirtFS requires libcap devel and libattr devel under > Linux" > + fi > + virtfs=no > + fi > + elif test "$darwin" = yes; then > virtfs=yes > - tools="$tools fsdev/virtfs-proxy-helper\$(EXESUF)"
So, no proxy helper on Darwin ? Why ? The limitation should be mentioned in the changelog at least. > else > if test "$virtfs" = yes; then > - error_exit "VirtFS requires libcap devel and libattr devel" > + error_exit "VirtFS is supported only on Linux and Darwin" > fi > virtfs=no > fi > + fi > + if test "$linux" = yes; then > if test "$mpath" != no && test "$mpathpersist" = yes ; then > mpath=yes > else > @@ -5555,10 +5566,6 @@ if test "$softmmu" = yes ; then > fi > tools="$tools scsi/qemu-pr-helper\$(EXESUF)" > else > - if test "$virtfs" = yes; then > - error_exit "VirtFS is supported only on Linux" > - fi > - virtfs=no > if test "$mpath" = yes; then > error_exit "Multipath is supported only on Linux" > fi
