Sure, I will list other involved files. Thanks for you suggestion. SU Hang
"Eric Blake" <ebl...@redhat.com>wrote: > On 05/24/2018 06:29 AM, Su Hang wrote: > > 'test.hex' file is a bare metal ARM software stored in Hexadecimal > > Object Format. When it's loaded by QEMU, it will print "Hello world!\n" > > on console. > > > > `pre_store` array in 'hexloader-test.c' file, stores the binary format > > of 'test.hex' file, which is used to verify correctness. > > > > Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> > > Suggested-by: Steffen Gortz <qemu...@steffen-goertz.de> > > Suggested-by: Stefan Hajnoczi <stefa...@redhat.com> > > Signed-off-by: Su Hang <suhan...@mails.ucas.ac.cn> > > --- > > MAINTAINERS | 6 ++++ > > configure | 4 +++ > > tests/Makefile.include | 2 ++ > > tests/hex-loader-check-data/test.hex | 12 ++++++++ > > tests/hexloader-test.c | 56 > > ++++++++++++++++++++++++++++++++++++ > > The previous patch also touched: > > hw/arm/boot.c | 7 +- > hw/core/loader.c | 246 > ++++++++++++++++++++++++++++++++++++++++++++++++++++ > include/hw/loader.h | 12 +++ > > > +++ b/MAINTAINERS > > @@ -1291,6 +1291,12 @@ F: hw/core/generic-loader.c > > F: include/hw/core/generic-loader.h > > F: docs/generic-loader.txt > > > > +Intel Hexadecimal Object File Loader > > +M: Su Hang <suhan...@mails.ucas.ac.cn> > > +S: Maintained > > +F: tests/hexloader-test.c > > +F: tests/hex-loader-check-data/test.hex > > + > > It looks odd having a maintainer that claims only test files; do you > want to also list some of the other files touched by this patch so that > you get notification if one of the implementation files has subsequent > patches (rather than just the test files)? > > -- > Eric Blake, Principal Software Engineer > Red Hat, Inc. +1-919-301-3266 > Virtualization: qemu.org | libvirt.org
