On 24 May 2018 at 16:50, Laurent Vivier <laur...@vivier.eu> wrote: > Le 24/05/2018 à 17:29, Laurent Vivier a écrit : >> Le 21/05/2018 à 11:19, Peter Maydell a écrit : >>> On 19 May 2018 at 10:29, Laurent Vivier <laur...@vivier.eu> wrote: >>>> to be like in the kernel and rename it TARGET_ARCH_HAS_SOCKET_TYPES >>> >>> You could note in the commit message that this fixes our >>> incorrect definition of TARGET_SOCK_CLOEXEC for SPARC. >> >> I agree > > In fact it doesn't change the value of TARGET_SOCK_CLOEXEC for SPARC, > because original value is 020000000 (0x400000) and the new value from > linux-user/socket.h is TARGET_O_CLOEXEC which is also 0x400000 for SPARC.
Argh, octal vs hex. Thanks for checking that. -- PMM
