On 23 May 2018 at 13:09, Auger Eric <eric.au...@redhat.com> wrote: > Hi Igor, > > On 05/23/2018 12:22 PM, Igor Mammedov wrote: >> When QEMU is started with following CLI >> -machine virt,gic-version=3,accel=kvm -cpu host -bios AAVMF_CODE.fd >> it crashes with abort at >> accel/kvm/kvm-all.c:2164: >> KVM_SET_DEVICE_ATTR failed: Group 6 attr 0x000000000000c665: Invalid >> argument >> >> Which is caused by implicit dependecy of kvm_arm_gicv3_reset() on > dependency >> arm_gicv3_icc_reset() where the later is called by CPU reset >> reset callback. >> >> However commit: >> 3b77f6c arm/boot: split load_dtb() from arm_load_kernel() >> broke CPU reset callback registration in case >> >> arm_load_kernel() >> ... >> if (!info->kernel_filename || info->firmware_loaded) >> >> branch is taken, i.e. it's sufficient to provide a firmware >> or do not provide kernel on CLI to skip cpu reset callback >> registration, where before offending commit the callback >> has been registered unconditionally. >> >> Fix it by registering the callback right at the begging of > beginning >> arm_load_kernel() unconditionally instead of doing it at the end. >> >> NOTE: >> we probably should eleminate that dependency anyways as well as > eliminate, anyway? >> separate arch CPU reset parts from arm_load_kernel() into CPU >> itself, but that refactoring that I probably would have to do >> anyways later for CPU hotplug to work. > may deserve some rewording. >> >> Reported-by: Auger Eric <eric.au...@redhat.com> >> Signed-off-by: Igor Mammedov <imamm...@redhat.com> > > Thank you for the quick fix. It fixes the reported issue. > > Reviewed-by: Eric Auger <eric.au...@redhat.com> > Tested-by: Eric Auger <eric.au...@redhat.com>
Thanks; applied to target-arm.next with the commit message typos fixed. -- PMM
