On Tue, Jan 25, 2011 at 08:17:32AM -0600, Anthony Liguori wrote: > On 01/11/2011 02:42 AM, Alon Levy wrote: > >diff --git a/libcacard/vscard_common.h b/libcacard/vscard_common.h > >new file mode 100644 > >index 0000000..9ff1295 > >--- /dev/null > >+++ b/libcacard/vscard_common.h > > This file (and the .c file) need a coding style pass to fixup > comments and the use of _ as a prefix but I want to focus on the > protocol itself. > > First, let's get a written spec into the wiki. I think it's > important that all of our compatibility protocols are documented in > a more formal way such that can be reviewed by a wider audience.
http://wiki.qeum.org/Features/Smartcard I'm still working on the rest, but you can review and comment on it. I've done a number of changes from the submitted here. I guess the idea is that iterations on the wiki can be faster? The changes done to the protocol: Removed Reconnect - doesn't scale easily, the same work should be done by whomever is initiating the migration, or via other mechanisms (i.e. spice) Added Flush/FlushComplete - still need to be able to tell client to wrap up the outstanding operations in any way. I'm planning on implementing this using register_savevm_live. Fixes suggested by you - set the enum, removed _ from surrounding #ifdef (btw - why does no one use #pragma once? IIUC it's supported by gcc?) The major issue I haven't tackled yet is the thread removal in ccid-card-emulated.c is that a blocker for integration? Can it be tackled later? Alon [snip]
