On 05/11/2018 08:06 AM, Alex Bennée wrote: > but...but... >>> -float16 float16_maybe_silence_nan(float16 a_, float_status *status) >>> + >>> +float16 float16_maybe_silence_nan(float16 a, float_status *status) >>> { >>> + if (float16_is_signaling_nan(a, status)) { >>> + float16_silence_nan(a, status); > > You need a return here.
Oops. > Amazing what tests pass with those in, but RISU picked them up. Heh. In my case I hadn't bothered testing until further down the patch set when these functions have been removed. r~