On 09/05/2018 17:06, Michael Walle wrote:
>>
>> All these calls into lm32_pic.c need to take the BQL.  They are all
>> wrong, but this one was unlucky (or lucky) enough to be caught.
>>
>> Paolo
> 
> my patch [1] from the beginning of this year just take the lock in
> op_helper.c.

Yes, I agree that's the best way to do it.

> The only other places are the gdbstub.c and
> lm32_cpu_dump_state(). So these are still missing, right?

Those should be called with BQL taken.

Paolo

> 
> -michael
> 
> [1] http://lists.gnu.org/archive/html/qemu-devel/2018-01/msg01598.html


Reply via email to