Re: [Qemu-devel] [PATCH 1/1] sandbox: avoid to compile options if CONFIG_SECCOMP undefined

[Yi Min Zhao]

在 2018/5/7 下午6:31, Eduardo Otubo 写道:

On 07/05/2018 - 11:32:14, Yi Min Zhao wrote:

If CONFIG_SECCOMP is undefined, the option 'elevatorprivileges' remains
complied. This would make libvirt set the corresponding capability and
then trigger the guest startup fails. So let's wrap the options with
CONFIG_SECCOMP.

Signed-off-by: Yi Min Zhao <zyi...@linux.ibm.com>
---
  vl.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/vl.c b/vl.c
index fce1fd12d8..cb07b19c02 100644
--- a/vl.c
+++ b/vl.c
@@ -268,6 +268,7 @@ static QemuOptsList qemu_sandbox_opts = {
              .name = "enable",
              .type = QEMU_OPT_BOOL,
          },
+#ifdef CONFIG_SECCOMP
          {
              .name = "obsolete",
              .type = QEMU_OPT_STRING,
@@ -284,6 +285,7 @@ static QemuOptsList qemu_sandbox_opts = {
              .name = "resourcecontrol",
              .type = QEMU_OPT_STRING,
          },
+#endif
          { /* end of list */ }
      },
  };
--
2.15.1 (Apple Git-101)

Acked-by: Eduardo Otubo <ot...@redhat.com>

Thanks for your review!