On 5 May 2018 at 22:59, Michael Clark <m...@sifive.com> wrote: > Okay, so an alternative is to call fdt_pack() and then fdt_totalsize(). > Thanks! > > QEMU has its own wrapper around libfdt and neither the fdt_pack() nor > fdt_totalsize() functions are exposed. > > Some architecture use only the wrapper functions provided by > qemu/include/include/sysemu/device_tree.h > > It seems that target/ppc has #include <libfdt.h> and calls fdt_pack() and > fdt_totalsize() directly.
Yeah, I find this combination of libfdt direct access and a QEMU wrapper layer a bit confusing. I think it's grown more than it's been actively designed. Your approach of doing direct calls to pack/totalsize is fine. Maybe the wrapper layer could be improved some day too. thanks -- PMM
