On 01/18/2011 04:28 PM, Jan Kiszka wrote:
>
> So we can either "infect" the whole device tree with kvm (or maybe a
> more generic accelerator structure that also deals with Xen) or we need
> to pull the reference inside the device's init function from some global
> service (kvm_get_state).
Note that this topic is still waiting for good suggestions, specifically
from those who believe in kvm_state references :). This is not only
blocking kvmstate merge but will affect KVM irqchips as well.
I'm one of them, but I don't have anything better to suggest than adding
"kvm_state" attribute to qdev, which seems mighty artificial. So I'm in
favour of eliminating it now.
It boils down to how we reasonably pass a kvm_state reference from
machine init code to a sysbus device. I'm probably biased, but I don't
see any way that does not work against the idea of confining access to
kvm_state or breaks device instantiation from the command line or a
config file.
I'm biased in the other direction, but I agree.
--
error compiling committee.c: too many arguments to function
