Anthony PERARD writes ("Re: [PATCH 03/16] xen: link against xentoolcore"): > On Thu, Apr 19, 2018 at 05:45:06PM +0100, Ian Jackson wrote: > > xen_pc="xencontrol xenstore xenguest xenforeignmemory xengnttab" > > - xen_pc="$xen_pc xenevtchn xendevicemodel" > > + xen_pc="$xen_pc xenevtchn xendevicemodel xentoolcore" > > I think we want to check if "xentoolcore" pkg_config exist before trying > to use it. Otherwith, that is not going to work with Xen older than > 4.10.
Yes. Thanks for spotting this. My tests were all with builds from in the Xen tree and I hadn't spotted that that is handled as a special case. > Instead, we could do this: > if $pkg_config --exists xentoolcore; then > xen_pc+=" xentoolcore" > fi I will test that. Ian.